Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete logo image stored in repo since it fetches from an external link #1532

Merged
merged 4 commits into from
Apr 14, 2024

Conversation

PrathamSikka24
Copy link
Contributor

Title: Add Missing Hyperledger Fabric Logo

Checklist

  • A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

This pull request addresses the issue where the Hyperledger Fabric logo was not displayed on the landing page, as described in issue #1531 .

Steps to Reproduce

  1. Navigate to the Hyperledger Caliper landing page.
  2. Scroll down to the "Supported Blockchains" section.
  3. Notice the absence of the Hyperledger Fabric logo, with only the alt text visible.

Existing issues

Design of the fix

The fix involved adding the missing logo image to the assets directory and updating the HTML source to point to the correct image file location. The previous image no longer existed.

Validation of the fix

The fix was validated locally by refreshing the landing page and confirming that the Hyperledger Fabric logo is now displayed correctly.

Automated Tests

No automated tests were added as this fix is related to the static content of the website.

What documentation has been provided for this pull request

The change is self-documenting; the addition of the image file is the only update required.

@davidkel
Copy link
Contributor

@PrathamSikka24 many thanks for the PR, unfortunately the commit isn't signed so we can't do anything with it. Please could you sign the commit and repush ?

@PrathamSikka24
Copy link
Contributor Author

@davidkel Thank you for bringing that to my notice. I've signed and re-pushed the commit. Please review it and let me know if anything else needs to be done.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than storing the image in our repo, we could just reference the one stored in the hyperledger fabric github repo which is
https://raw.githubusercontent.com/hyperledger/fabric/main/docs/source/images/hyperledger_fabric_logo_color.png

Hopefully then we would also pick up the logo change when it occurs.

@PrathamSikka24
Copy link
Contributor Author

We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one?

For now, I have committed the change as you've suggested. Please let me know in case of anything else.

@PrathamSikka24 PrathamSikka24 changed the title Add missing Hyperledger Fabric logo to landing page Delete logo image stored in repo since it fetches from an external link Apr 12, 2024
@PrathamSikka24
Copy link
Contributor Author

We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one?

I have incorporated the necessary suggestion for the image link. I apologize for mistakenly making an extra PR; please don't mind that. Do tell me if anything else needs to be done.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, many thanks for the contribution

@davidkel davidkel merged commit d1d784b into hyperledger-caliper:gh-pages Apr 14, 2024
2 checks passed
@davidkel davidkel linked an issue Apr 15, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Logo Image for Hyperledger Fabric on Landing Page
2 participants