-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete logo image stored in repo since it fetches from an external link #1532
Delete logo image stored in repo since it fetches from an external link #1532
Conversation
@PrathamSikka24 many thanks for the PR, unfortunately the commit isn't signed so we can't do anything with it. Please could you sign the commit and repush ? |
bf053fd
to
7f5cf02
Compare
@davidkel Thank you for bringing that to my notice. I've signed and re-pushed the commit. Please review it and let me know if anything else needs to be done. |
b3ebf56
to
f804fa8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than storing the image in our repo, we could just reference the one stored in the hyperledger fabric github repo which is
https://raw.githubusercontent.com/hyperledger/fabric/main/docs/source/images/hyperledger_fabric_logo_color.png
Hopefully then we would also pick up the logo change when it occurs.
Signed-off-by: PrathamSikka24 <[email protected]>
Signed-off-by: PrathamSikka24 <[email protected]>
Signed-off-by: PrathamSikka24 <[email protected]>
405ba1f
to
c03e1b0
Compare
We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one? For now, I have committed the change as you've suggested. Please let me know in case of anything else. |
Signed-off-by: Pratham Sikka <[email protected]>
We can reference the logo directly from the Hyperledger Fabric repo. However, the image in the link has a grey background, unlike our other UI images(logos of Hyperledger Besu, Ethereum), which are transparent. Could we find a transparent version or adapt this one? I have incorporated the necessary suggestion for the image link. I apologize for mistakenly making an extra PR; please don't mind that. Do tell me if anything else needs to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, many thanks for the contribution
Title: Add Missing Hyperledger Fabric Logo
Checklist
Issue/User story
This pull request addresses the issue where the Hyperledger Fabric logo was not displayed on the landing page, as described in issue #1531 .
Steps to Reproduce
Existing issues
Related issue: link to the GitHub issue you created
Design of the fix
The fix involved adding the missing logo image to the assets directory and updating the HTML source to point to the correct image file location. The previous image no longer existed.
Validation of the fix
The fix was validated locally by refreshing the landing page and confirming that the Hyperledger Fabric logo is now displayed correctly.
Automated Tests
No automated tests were added as this fix is related to the static content of the website.
What documentation has been provided for this pull request
The change is self-documenting; the addition of the image file is the only update required.