Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove besu as a adapter #1530

Closed

Conversation

kartikaysaxena
Copy link
Contributor

@kartikaysaxena kartikaysaxena commented Apr 10, 2024

Fixes #1529

Checklist

  • [x ] A link to the issue/user story that the pull request relates to
  • How to recreate the problem without the fix
  • Design of the fix
  • How to prove that the fix works
  • Automated tests that prove the fix keeps on working
  • Documentation - any JSDoc, website, or Stackoverflow answers?

Issue/User story

Steps to Reproduce

Existing issues

Design of the fix

Validation of the fix

Automated Tests

What documentation has been provided for this pull request

@kartikaysaxena kartikaysaxena requested a review from a team April 10, 2024 19:20
@davidkel
Copy link
Contributor

@kartikaysaxena Sorry I think you have misunderstood the issue here. Caliper still supports besu, but it doesn't have a separate Connector (Adapter) to do so, it re-uses the ethereum one. In the caliper docs under contributing, also referred to as the developer documentation, it describes that a caliper-besu package exists in the source which it doesn't. This is what the issue is referring to. I've updated the issue to make it more clear.

@kartikaysaxena
Copy link
Contributor Author

Sure @davidkel, I have taken in the suggestion and made changes accordingly to the issue in the v0.5.0 and vNext docs, I have created a continuation PR #1534, and closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caliper developer docs refer to a caliper-besu adapter but this doesn't exist
2 participants