Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test node 18/20, minimum version 18.19.0 #1517

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

davidkel
Copy link
Contributor

No description provided.

@davidkel davidkel requested a review from a team February 29, 2024 18:15
@davidkel davidkel force-pushed the testnode1820 branch 7 times, most recently from 81fa132 to b7e1e27 Compare March 1, 2024 11:29
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.85%. Comparing base (31b978f) to head (b7e1e27).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   55.85%   55.85%           
=======================================
  Files         105      105           
  Lines        4510     4510           
  Branches      689      689           
=======================================
  Hits         2519     2519           
  Misses       1437     1437           
  Partials      554      554           
Flag Coverage Δ
caliper-core 44.94% <ø> (ø)
caliper-fabric 80.46% <ø> (ø)
generator-caliper 83.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gave up trying to update the version of yo. It requires a lot more
investigation. So put in a hack workaround for now which is to ensure
lib/generators directory exists as without it the integration tests fail
saying that directory does not exist.

Signed-off-by: Dave Kelsey <[email protected]>
@davidkel davidkel force-pushed the testnode1820 branch 3 times, most recently from ad99017 to daa1214 Compare March 4, 2024 10:38
@davidkel davidkel mentioned this pull request Mar 4, 2024
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aklenik aklenik merged commit f24f777 into hyperledger-caliper:main Mar 16, 2024
16 checks passed
@davidkel davidkel deleted the testnode1820 branch October 5, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants