Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions workflow for docs #1424

Merged

Conversation

CaptainIRS
Copy link
Contributor

@CaptainIRS CaptainIRS commented Aug 1, 2022

In this PR:

  • GitHub actions workflows are added to the gh-pages branch
  • Issues pointed out by DCI lint are fixed for the latest and vNext docs

This is done because according to GitHub Docs:

The following steps occur to trigger a workflow run:
...
2. GitHub searches the .github/workflows directory in your repository for workflow files that are present in the associated commit SHA or Git ref of the event.

So, the workflow file is expected to be present in the gh-pages branch for it to run.

@CaptainIRS CaptainIRS force-pushed the docs-workflow-gh-pages branch 2 times, most recently from f5eea6c to 8b024ba Compare August 2, 2022 02:23
.github/workflows/pr.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor change on the workflow name, but looks good

Signed-off-by: CaptainIRS <[email protected]>
@CaptainIRS CaptainIRS requested a review from davidkel August 2, 2022 07:43
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 4716c73 into hyperledger-caliper:gh-pages Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants