Add DCI linting to CI of PRs #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Attila Klenik <[email protected]>
Signed-off-by: Attila Klenik <[email protected]>
Signed-off-by: Attila Klenik <[email protected]>
davidkel
reviewed
Jun 28, 2022
| @@ -216,7 +216,8 @@ describe('When using a PrometheusPushTxObserver', () => { | |||
|
|
|||
| await prometheusPushTxObserver.deactivate(); | |||
|
|
|||
| // Values should be zero, or empty (https://github.com/siimon/prom-client/blob/master/test/counterTest.js) | |||
| // Values should be zero, or empty | |||
| // Ref: https://github.com/siimon/prom-client/ file test/counterTest.js | |||
There was a problem hiding this comment.
this url doesn't look valid. If we can't use the real url then we should delete the line
There was a problem hiding this comment.
It's split into repo and file parts. I could structure it better if needed. But the entire file URL contains master...
Or we can remove it entirely
There was a problem hiding this comment.
@davidkel, could be structured like this:
See the "test/counterTest.js" file in https://github.com/siimon/prom-client/
There was a problem hiding this comment.
davidkel
reviewed
Jun 28, 2022
| @@ -181,7 +181,8 @@ describe('When using a PrometheusTxObserver', () => { | |||
|
|
|||
| await prometheusTxObserver.deactivate(); | |||
|
|
|||
| // Values should be zero, or empty (https://github.com/siimon/prom-client/blob/master/test/counterTest.js) | |||
| // Values should be zero, or empty | |||
| // Ref: https://github.com/siimon/prom-client/ file test/counterTest.js | |||
There was a problem hiding this comment.
this url doesn't look valid. If we can't use the real url then we should delete the line
davidkel
requested changes
Jun 28, 2022
Signed-off-by: Attila Klenik <[email protected]>
|
@davidkel The DCO check is stuck, can we re-trigger it somehow? |
Signed-off-by: Attila Klenik <[email protected]>
eravatee
pushed a commit
to eravatee/caliper
that referenced
this pull request
Oct 4, 2022
Signed-off-by: Attila Klenik <[email protected]> Signed-off-by: eravatee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended by the project update template and https://github.com/petermetz/gh-action-dci-lint
Let's see whether the remnant phrases in the changelog and third-party artifacts will trigger the alarm before making this a branch protection rule.
Signed-off-by: Attila Klenik [email protected]