-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer Gateway: Added Connector Selector implementation modifications to support the new Peer Gateway Connector #1298
Conversation
fraVlaca
commented
Apr 5, 2022
- added logic to pick new Peer Gateway connector in the connector selector in FabriConnectorFactory.js
- added 2.4 fabric SUT version with binding packages in .config.yaml
- added last fixes for the Peer Gateway connector implementation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor comments, but looking good.
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js
Outdated
Show resolved
Hide resolved
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js
Outdated
Show resolved
Hide resolved
packages/caliper-fabric/lib/connector-versions/peer-gateway/WalletFacade.js
Outdated
Show resolved
Hide resolved
packages/caliper-fabric/test/connector-versions/peer-gateway/PeerGateway.js
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mainly just typos to correct
…tor in FabriConnectorFactory.js + added 2.4 fabric SUT version with binding packages in .config.yaml + added last fixes for the Peer Gateway connector implementation Signed-off-by: fraVlaca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM