Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer Gateway: Added Connector Selector implementation modifications to support the new Peer Gateway Connector #1298

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

fraVlaca
Copy link
Contributor

@fraVlaca fraVlaca commented Apr 5, 2022

  • added logic to pick new Peer Gateway connector in the connector selector in FabriConnectorFactory.js
  • added 2.4 fabric SUT version with binding packages in .config.yaml
  • added last fixes for the Peer Gateway connector implementation

@davidkel davidkel self-requested a review April 5, 2022 11:06
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, but looking good.

Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mainly just typos to correct

…tor in FabriConnectorFactory.js + added 2.4 fabric SUT version with binding packages in .config.yaml + added last fixes for the Peer Gateway connector implementation

Signed-off-by: fraVlaca <[email protected]>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit 25f905d into hyperledger-caliper:main Apr 6, 2022
@davidkel davidkel linked an issue Apr 8, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a new fabric connector to utilise the new peer gateway api
2 participants