Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker monitor metrics fixes - cpu and memory usage #1214

Merged
merged 3 commits into from
Feb 7, 2022
Merged

Docker monitor metrics fixes - cpu and memory usage #1214

merged 3 commits into from
Feb 7, 2022

Conversation

fraVlaca
Copy link
Contributor

fixes #1166 and #1159.

  • adds normalization option for cpu usage metric of docker-monitor
  • fixes memory usage stat of docker-monitor

@fraVlaca fraVlaca mentioned this pull request Jan 31, 2022
Closed
4 tasks
davidkel
davidkel requested changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you include a unit test with this PR

@fraVlaca fraVlaca force-pushed the docker-monitor-fixes branch from f9a2d8a to 10c9a7e Compare February 3, 2022 12:01
@fraVlaca fraVlaca force-pushed the docker-monitor-fixes branch from 10c9a7e to 6fcedad Compare February 4, 2022 15:54
@fraVlaca fraVlaca requested a review from davidkel February 4, 2022 15:55
@fraVlaca fraVlaca force-pushed the docker-monitor-fixes branch from 6fcedad to f1d120a Compare February 7, 2022 14:18
@fraVlaca fraVlaca force-pushed the docker-monitor-fixes branch from f1d120a to 32eece1 Compare February 7, 2022 15:42
davidkel
davidkel approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit caad464 into hyperledger-caliper:main Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkel davidkel davidkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker monitor should normalize CPU performances according to number of cores
2 participants
@fraVlaca @davidkel