Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where init flow errors when not using mutual TLS #1183

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

davidkel
Copy link
Contributor

@davidkel davidkel commented Dec 7, 2021

although init flows should not be used with the new connectors if you do it shouldn't fail but it fails with the following error if you aren't using mutual TLS

TypeError: this.connectorConfiguration.getConnectionProfileDefinitionForOrganization(...).isTLSEnabled is not a function

closes #1160
Signed-off-by: D [email protected]

fixes the issue where on the init flow you get

TypeError:
this.connectorConfiguration.getConnectionProfileDefinitionForOrganization(...).isTLSEnabled
is not a function

closes hyperledger-caliper#1160
Signed-off-by: D <[email protected]>
@davidkel davidkel requested a review from aklenik December 7, 2021 15:49
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidkel davidkel merged commit 595942a into hyperledger-caliper:main Dec 9, 2021
@davidkel davidkel deleted the fixconn branch December 9, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New fabric connector crashes if you try to use the init flow without mutual TLS
2 participants