Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic value providers in workload module #1164

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

bistaastha
Copy link
Contributor

  • Added value-provider-interface and uniform-random-value-provider
  • Added unit tests for value providers
  • UniformRandomValueProvider test fix and reference value provider addition

Signed-off-by: Aastha Bist [email protected]

@bistaastha bistaastha marked this pull request as ready for review September 21, 2021 11:29
@bistaastha bistaastha marked this pull request as draft September 21, 2021 11:30
@aklenik aklenik self-assigned this Sep 21, 2021
@aklenik aklenik added the mentorship-2021 Contribution as part of the LFX Hyperledger Mentorship 2021 label Sep 21, 2021
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more checks are still needed once the default parameter values are changed (back to undefined). Tests should be updated accordingly.

unit tests for the base classes.

Signed-off-by: Aastha Bist <[email protected]>
@bistaastha bistaastha force-pushed the value-provider-base branch from c85c6c4 to 0053563 Compare October 1, 2021 13:17
@bistaastha bistaastha marked this pull request as ready for review October 1, 2021 13:18
@aklenik aklenik merged commit ea77aa0 into hyperledger-caliper:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mentorship-2021 Contribution as part of the LFX Hyperledger Mentorship 2021
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants