Extract identities from a version specific wallet and store in the in memory wallet #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RosieMurphy0 <[email protected]>
… memory wallet Signed-off-by: RosieMurphy0 <[email protected]>
… memory wallet Signed-off-by: RosieMurphy0 <[email protected]>
Signed-off-by: RosieMurphy0 <[email protected]>
Signed-off-by: RosieMurphy0 <[email protected]>
davidkel
reviewed
Oct 15, 2020
| @@ -191,7 +191,14 @@ class IdentityManager { | |||
| * @private | |||
| */ | |||
| async _extractIdentitiesFromWallet(mspId, wallet) { | |||
| // TODO: To be implemented | |||
| const walletFacade = await this.walletFacadeFactory.create(wallet.path); | |||
| const allIDNames = await walletFacade.getAllIdentityNames(); | |||
There was a problem hiding this comment.
could you change allIDNames to allIdentityNames as we don't want to use abbreviations
davidkel
reviewed
Oct 15, 2020
| const walletFacade = await this.walletFacadeFactory.create(wallet.path); | ||
| const allIDNames = await walletFacade.getAllIdentityNames(); | ||
| // eslint-disable-next-line no-console | ||
| console.log({allIDNames}); |
There was a problem hiding this comment.
Looks like you left some debug code in, could you delete the console.log and the comment above it as well.
davidkel
reviewed
Oct 15, 2020
| const allIDNames = await walletFacade.getAllIdentityNames(); | ||
| // eslint-disable-next-line no-console | ||
| console.log({allIDNames}); | ||
| for (const identityName in allIDNames){ |
There was a problem hiding this comment.
allIDNames to allIdentityNames here too, plus change the in to of which means you will get the individual identityName as it loops round
davidkel
reviewed
Oct 15, 2020
| console.log({allIDNames}); | ||
| for (const identityName in allIDNames){ | ||
| const identity = await walletFacade.export(identityName); | ||
| await this._addToWallet(identity.mspid, allIDNames[identityName], identity.certificate, identity.privateKey); |
There was a problem hiding this comment.
with the change to of in the for loop, you can replace the allIDNames[identityName] with just identityName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the _extractIdentitiesFromWallet method in the identity manager and the associated tests for the method. Takes identities from a wallet and stores them in the in memory wallet using an existing method.
contributes to #940