Extracts identities from a wallet and stores in the in memory wallet #1051
Conversation
Signed-off-by: RosieMurphy0 <[email protected]>
| @@ -184,7 +184,14 @@ class IdentityManager { | |||
| * @private | |||
| */ | |||
| async _extractIdentitiesFromWallet(mspId, wallet) { | |||
| // TODO: To be implemented | |||
| const walletFacade = await this.walletFacadeFactory.create(wallet.path); | |||
| const allIDNames = await walletFacade.getAllIdentityNames(); | |||
There was a problem hiding this comment.
allIDNames --> allIdentityNames for this line and the next line
| // TODO: To be implemented | ||
| const walletFacade = await this.walletFacadeFactory.create(wallet.path); | ||
| const allIDNames = await walletFacade.getAllIdentityNames(); | ||
| for (const identityNames in allIDNames){ |
There was a problem hiding this comment.
identityNames --> identityName
| const allIDNames = await walletFacade.getAllIdentityNames(); | ||
| for (const identityNames in allIDNames){ | ||
| const identity = await walletFacade.export(identityNames); | ||
| if (identity){ |
There was a problem hiding this comment.
we can remove this check as we should expect something to be returned as the wallet has given the list of all available identity names
| const walletFacade = await this.walletFacadeFactory.create(wallet.path); | ||
| const allIDNames = await walletFacade.getAllIdentityNames(); | ||
| for (const identityNames in allIDNames){ | ||
| const identity = await walletFacade.export(identityNames); |
There was a problem hiding this comment.
identityNames --> identityName
| @@ -386,4 +405,56 @@ describe('An Identity Manager', () => { | |||
| const identityManager = await identityManagerFactory.create(stubWalletFacadeFactory, [org1MSP, org2MSP]); | |||
| await identityManager.getWallet().should.equal('IamAwallet'); | |||
| }); | |||
|
|
|||
| describe('when extracting identities from a specific wallet and store in the in memory wallet', () => { | |||
There was a problem hiding this comment.
Can just say when extracting identities from a specific wallet
|
|
||
| describe('when extracting identities from a specific wallet and store in the in memory wallet', () => { | ||
|
|
||
| it('if not identities available should not add anything to wallet', async () => { |
There was a problem hiding this comment.
should not add anything to the wallet when no identities are available
| const stubWalletFacadeFactory = sinon.createStubInstance(IWalletFacadeFactory); | ||
| const spyWalletFacade = sinon.createStubInstance(IWalletFacade); | ||
| stubWalletFacadeFactory.create.resolves(spyWalletFacade); | ||
| spyWalletFacade.getAllIdentityNames.resolves([]); |
There was a problem hiding this comment.
This isn't a spy, it's a stub
| const identityManagerFactory = new IdentityManagerFactory(); | ||
|
|
||
| const identityManager = await identityManagerFactory.create(stubWalletFacadeFactory, [org4MSP]); | ||
| await identityManager._extractIdentitiesFromWallet(org4MSP, spyWalletFacade); |
There was a problem hiding this comment.
Unfortunately the _ indicates a private method so the tests should not be calling that method directly but it should be driven through the use of appropriate external configurations.
| const identityManagerFactory = new IdentityManagerFactory(); | ||
|
|
||
| const identityManager = await identityManagerFactory.create(stubWalletFacadeFactory, [org4MSP]); | ||
| await identityManager._extractIdentitiesFromWallet(org4MSP, stubWalletFacade); |
There was a problem hiding this comment.
again, this method should not be called directly by the test
| const stubAddToWallet = sinon.stub(); | ||
| identityManager._addToWallet = stubAddToWallet; | ||
|
|
||
| await identityManager._extractIdentitiesFromWallet(org4MSP, stubWalletFacade); |
There was a problem hiding this comment.
Should not be called directly
… memory wallet Signed-off-by: RosieMurphy0 <[email protected]>
… memory wallet Signed-off-by: RosieMurphy0 <[email protected]>
Signed-off-by: RosieMurphy0 <[email protected]>
Signed-off-by: RosieMurphy0 [email protected]
Implemented the
_extractIdentitiesFromWalletmethod in the identity manager and the associated tests for the method. Takes identities from a wallet and stores them in the in memory wallet using an existing method.contributes to #940