You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
there is no issue with a docker monitor and it also looks like from the code that if an attempt to push data to a prometheus push gateway fails then it will just log it, so I think that this is more of a bug than an enhancement, so changing to bug. The only thing is that from an integration test point of view if for some reason it is supposed to work but doesn't (eg url is wrong and so prometheus is not found) then the build would still pass.
davidkel
changed the title
test runs should have the option to not fail if a monitor can't connect to an external port
Test runs should not fail if it's not possible to extract prometheus data
Mar 23, 2022
davidkel
pushed a commit
to davidkel/caliper
that referenced
this issue
Mar 24, 2022
This is due to the error event not being correctly captured when a
request is made to prometheus
Also added some extra code to output a warning and stop trying to do any
more queries for the round.
It won't stop it for all rounds but checks on every round.
closeshyperledger-caliper#1267
davidkel
pushed a commit
to davidkel/caliper
that referenced
this issue
Mar 24, 2022
This is due to the error event not being correctly captured when a
request is made to prometheus
Also added some extra code to output a warning and stop trying to do any
more queries for the round.
It won't stop it for all rounds but checks on every round.
closeshyperledger-caliper#1267
Signed-off-by: D <[email protected]>
This is due to the error event not being correctly captured when a
request is made to prometheus
Also added some extra code to output a warning and stop trying to do any
more queries for the round.
It won't stop it for all rounds but checks on every round.
closes#1267
Signed-off-by: D <[email protected]>
Co-authored-by: D <[email protected]>
In the case of prometheus we can specify a monitor to extract data from prometheus, however if prometheus isn't available you get
And caliper terminates.
This is really annoying because now I can't use a benchmark which defines a monitor for prometheus if I choose not to have prometheus running.
It should not fail the run, just report a warning or at least have an option that stops it from failing the run
The text was updated successfully, but these errors were encountered: