Skip to content

Commit

Permalink
test node 18/20, minimum version 18.19.0
Browse files Browse the repository at this point in the history
- concern here is that although this passes the tests (which now fail
due to the node version change which is really strange) what effect this
will have on the final packaged version of the generator.

Signed-off-by: Dave Kelsey <[email protected]>
  • Loading branch information
Dave Kelsey committed Mar 1, 2024
1 parent 31b978f commit 945fc56
Show file tree
Hide file tree
Showing 19 changed files with 546 additions and 267 deletions.
2 changes: 1 addition & 1 deletion .build/check-prerequisites.sh
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ check_npm_version() {
}

check_node_version() {
required_version="14.19.0"
required_version="18.19.0"
installed_version=$(node --version | cut -c2-)
versions="$required_version\n$installed_version"
if echo -e $versions | sort -rV | head -n 1 | grep -q "$installed_version"; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/integration-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
fail-fast: false
matrix:
adaptor: ${{ fromJSON(needs.changes.outputs.adaptor) }}
node-version: [14.x, 16.x]
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x]
node-version: [18.x, 20.x]
steps:
- uses: actions/checkout@v3
- name: Use Node.js ${{ matrix.node-version }}
Expand Down
783 changes: 531 additions & 252 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"force-clean": "./scripts/force-clean.sh"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=7.24.2"
},
"dependencies": {},
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-ethereum/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-fabric/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
4 changes: 2 additions & 2 deletions packages/caliper-gui-dashboard/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"map-sass": "node-sass src/assets/scss/paper-dashboard.scss src/assets/css/paper-dashboard.css --source-map true"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand All @@ -38,7 +38,7 @@
"history": "4.10.1",
"js-yaml": "^3.13.1",
"mime-types": "^2.1.24",
"node-sass": "7.0.1",
"node-sass": "9.0.0",
"patternomaly": "^1.3.2",
"perfect-scrollbar": "1.5.0",
"react": "^16.12.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-gui-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"start": "node app.js"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-publish/caliper.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# limitations under the License.
#

FROM node:14.19-alpine
FROM node:18.19-alpine

# require to set these explicitly to avoid mistakes
ARG npm_registry
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-publish/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/caliper-tests-integration/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"private": true,
"description": "Integration tests for Hyperledger Caliper",
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion packages/generator-caliper/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"nyc": "nyc --reporter=text --reporter=clover mocha --recursive -t 10000"
},
"engines": {
"node": ">=14.19.0",
"node": ">=18.19.0",
"npm": ">=6.14.16"
},
"files": [
Expand Down

0 comments on commit 945fc56

Please sign in to comment.