-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(github): add dependency version consistency check #3699
base: main
Are you sure you want to change the base?
ci(github): add dependency version consistency check #3699
Conversation
66ae30d
to
ba33a40
Compare
@petermetz I have created multiple tickets to address the fix for this (#3684 till #3698) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Almost perfect, just please add the currently bad dependencies to the ignore list so that when we merge this PR the custom checks are passing.
Then we can remove the ignore declarations as we fix the problems chunk by chunk and finally (hopefully) end up with no ignores at all.
@petermetz shall I add the ignore list with packages in it (instead of dependencies)? This is because the way we are targetting a fix for this on |
2f7214c
to
677635a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan Yes, that works as well, in this regard, I'm OK with whatever is more convenient because eventually we'll empty out the list either way. Thank you!
Primary Changes --------------- 1. Added a new custom check which checks if there are any inconsistency with the dependency version, which is already being used with an exsisting package. Changes needed to incorporate 1) ------------------------------- 2. Added a new dependency in the root package.json 3. Added a new npm script in the root package.json 4. Updated the lock file for the dependency inclusion Fixes hyperledger-cacti#3612 Signed-off-by: jagpreetsinghsasan <[email protected]>
677635a
to
81006fc
Compare
Commit to be reviewed
ci(github): add dependency version consistency check
Fixes #3612
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.