Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quorum-connector): add script for checking connection status #2310

Merged
merged 1 commit into from
Jun 13, 2023
Merged

feat(quorum-connector): add script for checking connection status #2310

merged 1 commit into from
Jun 13, 2023

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Mar 3, 2023

  • Simple script will check ledger connection by getting block through the connector.

Closes: #2309

@outSH outSH force-pushed the quorum_status_script_pr branch from 3a423a4 to ed4d5c6 Compare March 3, 2023 14:23
izuru0
izuru0 approved these changes Mar 12, 2023
View reviewed changes
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jagpreetsinghsasan
jagpreetsinghsasan approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

petermetz
petermetz requested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM just please

  1. order the dependencies in the package.json alphabetically and
  2. resolve the merge conflict

packages/cactus-plugin-ledger-connector-quorum/package.json Outdated Show resolved Hide resolved
@outSH outSH force-pushed the quorum_status_script_pr branch from ed4d5c6 to 96043e2 Compare March 28, 2023 10:17
@outSH outSH requested review from petermetz and removed request for VRamakrishna, sandeepnRES and takeutak March 28, 2023 10:18
petermetz
petermetz approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Thank you, LGTM!

@petermetz petermetz mentioned this pull request Mar 29, 2023
Closed
petermetz
petermetz requested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Please fix the merge conflicts and then we are good to go!

@outSH outSH force-pushed the quorum_status_script_pr branch from 96043e2 to 646dd9e Compare May 8, 2023 10:55
@outSH outSH requested a review from petermetz May 8, 2023 10:55
@petermetz petermetz force-pushed the quorum_status_script_pr branch from 646dd9e to 545eb6b Compare June 12, 2023 18:57
petermetz
petermetz approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH LGTM

FYI: I resolved the merge conflicts and rebased onto upstream/main so this is ready to merge now.

@outSH @petermetz
feat(quorum-connector): add script for checking connection status
7c69ab7 
- Simple script will check ledger connection by getting block through the connector.

Closes: hyperledger-cacti#2309

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Michal Bajer <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the quorum_status_script_pr branch from 545eb6b to 7c69ab7 Compare June 12, 2023 21:09
petermetz
petermetz reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH FYI: I resolved the merge conflicts again (another PR introduced new ones)

@petermetz petermetz merged commit d306d21 into hyperledger-cacti:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermetz petermetz petermetz approved these changes

@jagpreetsinghsasan jagpreetsinghsasan jagpreetsinghsasan approved these changes

@izuru0 izuru0 izuru0 approved these changes

@VRamakrishna VRamakrishna Awaiting requested review from VRamakrishna VRamakrishna is a code owner

@sandeepnRES sandeepnRES Awaiting requested review from sandeepnRES sandeepnRES is a code owner

@takeutak takeutak Awaiting requested review from takeutak takeutak is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(quorum-connector): add script for checking connection status
4 participants
@outSH @petermetz @jagpreetsinghsasan @izuru0