feat: allows for constructor args in quorum contract deploy #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
- Coverage 70.41% 70.37% -0.04%
==========================================
Files 301 302 +1
Lines 10820 10917 +97
Branches 1320 1338 +18
==========================================
+ Hits 7619 7683 +64
- Misses 2507 2528 +21
- Partials 694 706 +12
Continue to review full report at Codecov.
|
travis-payne
force-pushed
the
deploy-contract-args
branch
from
91da52d to
c4912ee
Compare
travis-payne
requested review from
jonathan-m-hamilton and
petermetz
as code owners
takeutak
approved these changes
Sep 30, 2021
petermetz
reviewed
Sep 30, 2021
packages/cactus-plugin-ledger-connector-quorum/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Sep 30, 2021
packages/cactus-plugin-ledger-connector-quorum/src/main/json/openapi.json
Outdated
Show resolved
Hide resolved
...ntegration/plugin-ledger-connector-quorum/deploy-contract/openapi/openapi-validation.test.ts
Outdated
Show resolved
Hide resolved
...ledger-connector-quorum/deploy-contract/v2.3.0-deploy-contract-from-json-json-object.test.ts
Outdated
Show resolved
Hide resolved
...tion/plugin-ledger-connector-quorum/deploy-contract/v2.3.0-deploy-contract-from-json.test.ts
Outdated
Show resolved
Hide resolved
petermetz
requested changes
Oct 6, 2021
There was a problem hiding this comment.
@travis-payne Please fix the CI, rebase, squash, etc. the usual chores.
travis-payne
force-pushed
the
deploy-contract-args
branch
from
4a748a7 to
3a16b89
Compare
travis-payne
force-pushed
the
deploy-contract-args
branch
from
3a16b89 to
4d06ec1
Compare
|
@travis-payne Why the close? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #962
Signed-off-by: Travis Payne [email protected]