-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connector-iroha): adds connector plugin #1169
Conversation
hanxu12
commented
Jul 26, 2021
•
edited
Loading
edited
- Enables Cactus to manipulate Iroha ledger
- Supports 19/20 commands and 14/15 queries of the Iroha ledger. (removePeer and fetchCommits have not been fully implemented)
- Possibility of starting Iroha and Postgres with random ports.
- Possibility of passing arbitrary Iroha admin/node keypairs to the test ledger.
- Offers a comprehensive run transaction test suite to validate the support for Iroha ledger commands and queries.
- Provides an example of asset transfer between two separate Iroha nodes.
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 71.83% 71.69% -0.14%
==========================================
Files 278 292 +14
Lines 10019 10525 +506
Branches 1242 1282 +40
==========================================
+ Hits 7197 7546 +349
- Misses 2159 2302 +143
- Partials 663 677 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hxlaf The contents under packages/cactus-test-tooling/src/main/typescript/iroha/example/
can be safely deleted I assume? Or if they are needed for something then we need to find them a different location because the ./src/main/
folder is designed to hold only code that is meant to be deployed to production (so the directory called example does not sound like it should be in there)
...r-connector-iroha/docs/architecture/run-transaction-endpoint-transact-cactuskeychainref.puml
Outdated
Show resolved
Hide resolved
...nector-iroha/src/main/typescript/web-services/get-prometheus-exporter-metrics-endpoint-v1.ts
Outdated
Show resolved
Hide resolved
...s-plugin-ledger-connector-iroha/src/main/typescript/web-services/run-transaction-endpoint.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
43a4734
to
97b25a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked all not generated automatically files with "iroha" in directory path. I see 100 files modified, rather not all of them by You so I suggest to remove files not modified by You from the PR - it would be easier for reviewers:). E.g. file rather not modified by You: docs/source/support/xdai.md
I'm not TypeScript specialist, so I've ignored many things connected with style (left commented code).
...es/cactus-plugin-ledger-connector-iroha/src/main/typescript/plugin-ledger-connector-iroha.ts
Show resolved
Hide resolved
...es/cactus-plugin-ledger-connector-iroha/src/main/typescript/plugin-ledger-connector-iroha.ts
Show resolved
Hide resolved
packages/cactus-test-tooling/src/main/typescript/iroha/iroha-test-ledger.ts
Outdated
Show resolved
Hide resolved
packages/cactus-test-tooling/src/main/typescript/postgres/postgres-test-container.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Outdated
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Show resolved
Hide resolved
...n-ledger-connector-iroha/src/test/typescript/integration/run-transaction-endpoint-v1.test.ts
Show resolved
Hide resolved
...ages/cactus-plugin-ledger-connector-iroha/src/main/typescript/prometheus-exporter/metrics.ts
Show resolved
Hide resolved
...s-plugin-ledger-connector-iroha/src/main/typescript/web-services/run-transaction-endpoint.ts
Outdated
Show resolved
Hide resolved
65bfcd0
to
9a06146
Compare
5577cee
to
1c0b9cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are few lines of commented code, but not much, but the PR looks good for me (Hyperledger Iroha's site).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hxlaf If you fix the commit lint issue afterwards it should be good to go |
Thank you! Will talk to you tomorrow! |
@petermetz Thanks for contributing! (1) Iroha connector using python can coexist with this product because of the difference of the communication type and language. If you agree with the above plans, I can immediately approve these works because these works #1169 #1183 is independent of the works on the above plans. |
71140ed
to
257d84c
Compare
3651507
to
c0f041f
Compare
1. Enables Cactus to manipulate Iroha ledger 2. Supports 19/20 commands and 14/15 queries of the Iroha ledger 3. Possibility of starting Iroha and Postgres with random ports 4. Possibility of passing arbitrary Iroha admin/node keypairs to the test ledger 5. Offers a comprehensive transaction test suite to validate support for Iroha commands and queries 6. Provides an example of asset transfer between two separate Iroha nodes Signed-off-by: im8a <[email protected]>