feat(connector-fabric): identity json signing credentials #1130 #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1132 +/- ##
==========================================
- Coverage 73.14% 73.09% -0.06%
==========================================
Files 246 247 +1
Lines 8617 8664 +47
Branches 996 1008 +12
==========================================
+ Hits 6303 6333 +30
- Misses 1783 1790 +7
- Partials 531 541 +10
Continue to review full report at Codecov.
|
takeutak
approved these changes
Jul 15, 2021
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
…-cacti#1130 Introduces a new, optional (for now) parameter on the run tx endpoint's request object called gatewayOptions which is capable of including everything that one needs to instantiate a gateway object of the underlying Fabric Node SDK. This change makes it possible to not need the keychain plugin at all when someone does not need/want it. Fixes hyperledger-cacti#1130 Depends on hyperledger-cacti#1124 Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new, optional (for now) parameter on the run tx
endpoint's request object called gatewayOptions which is capable
of including everything that one needs to instantiate a gateway
object of the underlying Fabric Node SDK.
This change makes it possible to not need the keychain plugin
at all when someone does not need/want it.
Fixes #1130
Depends on #1124
Signed-off-by: Peter Somogyvari [email protected]