Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): Files needs to migrated from Tape to Jest #1465

Open
awadhana opened this issue Oct 20, 2021 · 1 comment · May be fixed by #3737
Open

fix(logger): Files needs to migrated from Tape to Jest #1465

awadhana opened this issue Oct 20, 2021 · 1 comment · May be fixed by #3737
Assignees
@ruzell22
Labels
Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@awadhana
Copy link
Contributor

Describe the bug

Test file, logger, has a method that is being skipped.

Expected behavior

The test file should be able to run without it's method being skipped.

File Path: packages/cactus-common/src/test/typescript/unit/logging/logger.test.ts

After Correction
Migrate file from Tape to Jest.

Engineering Note:
@petermetz petermetz added Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc. labels Oct 21, 2021
@jagpreetsinghsasan
Copy link
Contributor

Increasing the scope of this task to include the fix for the same as well (in case if it doesn't work by removing the .skip function to the tape test)

ruzell22 added a commit to ruzell22/cactus that referenced this issue Jan 28, 2025
@ruzell22
fix(logger): files needs to migrated from Tape to Jest
d4322c2 
Primary Changes
---------------
1. Updated logger-provider.ts and logger.ts for LoggerProvider configuration
and added a way for optional custom writable stream
2. Using the custom writable stream, fixed logger.test.ts after removing the
skip on the test and UUID marker now appears in the custom stream output
3. Migrated test file from tape to jest
4. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes: hyperledger-cacti#1465

Signed-off-by: ruzell22 <[email protected]>
@ruzell22 ruzell22 mentioned this issue Jan 28, 2025
Closed
5 tasks
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jan 28, 2025
@ruzell22
fix(logger): files needs to migrated from Tape to Jest
cfac339 
Primary Changes
---------------
1. Updated logger-provider.ts and logger.ts for LoggerProvider configuration
and added a way for optional custom writable stream
2. Using the custom writable stream, fixed logger.test.ts after removing the
skip on the test and UUID marker now appears in the custom stream output
3. Migrated test file from tape to jest
4. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes: hyperledger-cacti#1465

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Jan 28, 2025
@ruzell22
fix(logger): files needs to migrated from Tape to Jest
c2ffdbd 
Primary Changes
---------------
1. Updated logger-provider.ts and logger.ts for LoggerProvider configuration
and added a way for optional custom writable stream
2. Using the custom writable stream, fixed logger.test.ts after removing the
skip on the test and UUID marker now appears in the custom stream output
3. Migrated test file from tape to jest
4. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes: hyperledger-cacti#1465

Signed-off-by: ruzell22 <[email protected]>
ruzell22 added a commit to ruzell22/cactus that referenced this issue Feb 4, 2025
@ruzell22
fix(logger): files needs to migrated from Tape to Jest
37177f2 
Primary Changes
---------------
1. Fixed logger.test.ts after removing the skip on the test and UUID marker
now appears in the custom stream output
2. Migrated test file from tape to jest test
3. Removed file path of logger.test.ts in testPathIgnorePatterns to run jest
test

Fixes: hyperledger-cacti#1465

Signed-off-by: ruzell22 <[email protected]>
@ruzell22 ruzell22 linked a pull request Feb 4, 2025 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruzell22 ruzell22

Labels
Developer_Experience Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) Hacktoberfest Hacktoberfest participants are welcome to take a stab at issues marked with this label. Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Milestone
No milestone
4 participants
@petermetz @awadhana @jagpreetsinghsasan @ruzell22