[substrate] platform deployment via Helm #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saurabhkumarkardam
requested review from
sownak,
suvajit-sarkar,
jagpreetsinghsasan,
arsulegai,
weihong-ou and
adityajoshi12
as code owners
6 tasks
saurabhkumarkardam
force-pushed
the
substrate-2484
branch
from
dde22ac to
197a350
Compare
sownak
requested changes
Apr 16, 2024
saurabhkumarkardam
force-pushed
the
substrate-2484
branch
from
197a350 to
4954128
Compare
sownak
approved these changes
Apr 18, 2024
|
LGTM |
saurabhkumarkardam
force-pushed
the
substrate-2484
branch
from
4954128 to
2d3cb24
Compare
This pull request introduces enhanced functionality to deploy the Substrate platform using Helm charts. Several improvements have been made to streamline the process and increase readability: 1. Substrate-genesis: - The substrate-genesis Helm chart now dynamically generates keys and updates the genesis.json file accordingly. - Eliminates the need for the substrate-key-chart Helm chart, achieving the same functionality within the substrate-genesis chart. - Once the entire Substrate codebase is updated, substrate-key-mgmt can be safely removed. 2. Substrate-node: - The substrate-node chart handles node deployment, simplifying the overall process. - Improved readability and maintainability by removing the repetetive code and containers such as node-secrets, retrieve-chain-spec, inject-keys, and query-services. - Their functionalities have been incorporated into the main container responsible for starting the node. 3. dscp-ipfs-node - Updated for deployment via Helm. 4. A README.md has been added at the path ./platform/substrate/charts/ to provide guidance for deploying the Substrate platform via Helm. These enhancements aim to streamline Substrate deployment via Helm, making the process more efficient and the codebase easier to manage. fixes hyperledger-bevel#2484 Signed-off-by: saurabhkumarkardam <[email protected]>
saurabhkumarkardam
force-pushed
the
substrate-2484
branch
from
2d3cb24 to
1bcbf68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(substrate): platform deployment via Helm
fixes #2484