support setting ZMQ socks proxy

[vitalrev]

implementation for issue #2399

Signed-off-by: Vitalij Reicherdt [email protected]

[dhh1128]

Nice solution to a pesky problem! Thank you!

[vitalrev]

Thanks!
As first-time contributor, i can not merge this pull request by my self.
Waiting for approval and merge from a maintainer with write access...

[dhh1128]

Although I have rights to merge, I am not as close to this code as I used to be. I suggest that we get @jovfer to review.

Sergey, this PR looks very straightforward; <1 min for you to review. If you give your approval, I will merge it?

[jovfer]

@vitalrev Please take a look on API params related to pool open operation https://github.com/hyperledger/indy-sdk/blob/master/libindy/src/api/pool.rs#L68-L82
Should this ZMQ setting be a part of API params or do you suggest to ignore api capability and use env variable for the setting?

@dhh1128 thanks for the heads up.

PS: initially the config was used for different kind of settings, so this is rather a question, not a change request

[vitalrev]

@jovfer thank you for support!
what you mean is the pool configuration here and Socket creation here
This is an inproc://{} socket for ØMQ local in-process (inter-thread) communication transport.

But we need the socks proxy configuration only for the communication to the remote nodes via tcp://... and this is implemented in networker.rs RemoteNode.connect.

[jovfer]

@vitalrev sorry, didn't get your point.

The pool config from API goes down to the service as you linked
but then it's forwarded not to internal sockets, but to Pool::new(...) here. Finally the config structure is split to separate values and some of them is available in RemotNode.connect.

[vitalrev]

@jovfer ok, I'm trying to include the socks_proxy config in the PoolOpenConfig and pass it on to RemoteNode.

[vitalrev]

@jovfer I rebuilt it ... it became a little more than 2 lines of code. I hope it goes with your suggestion.
Please review

[dhh1128]

I am going to merge this, now that @jovfer has approved. Just waiting on builds to pass.

[vitalrev]

I am going to merge this, now that @jovfer has approved.

thank you!