This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
Updated mac-build guidelines #2152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Achudh thanks for contribution, to get this merged you have to take 1 more step. Please follow instructions here https://github.com/hyperledger/indy-sdk/blob/master/docs/contributors/signing-commits.md The easiest way would be to run on your branch: In order to add the sign off to the commit message. And then push force it. |
|
@Patrik-Stas I’m extremely sorry, forgot about this PR ! Will resolve it asap if the bug still exists |
WadeBarnes
added
the
wont-address-project-depreciated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting LD_LIBRARY_PATH no longer works due to SIP: oracle/node-oracledb#231