Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Fix Travis build issues #2267

Merged
merged 4 commits into from
Jul 22, 2016

Conversation

juliancarrivick-ibm
Copy link
Contributor

Description

Attempt to re juggle the python package installations in scripts/provision/host.sh

Motivation and Context

Fixes #2266
New Pull Requests won't pass the Travis CI tests if this is not fixed.

How Has This Been Tested?

None needed, trying to get the tests to run correctly in Travis.

Checklist:

  • I have added a Signed-off-by.
  • I have either added documentation to cover my changes or this change requires no new documentation.
  • I have either added unit tests to cover my changes or this change requires no new tests.
  • I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Julian Carrivick [email protected]

@dco-bot
Copy link

dco-bot commented Jul 21, 2016

Hi juliancarrivick-ibm,

Thanks for submitting this pull request!

I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request.

dco-bot

@juliancarrivick-ibm
Copy link
Contributor Author

reverify travis

Passed 1st time: re-verifying as I found issue to be intermittent and want to make sure this fixes it

juliancarrivick-ibm added a commit to juliancarrivick-ibm/fabric that referenced this pull request Jul 21, 2016
@juliancarrivick-ibm juliancarrivick-ibm changed the title [WIP] Attempt to fix Travis build issues Fix Travis build issues Jul 21, 2016
@juliancarrivick-ibm
Copy link
Contributor Author

Ready to be merged sans feedback!

@christo4ferris
Copy link
Contributor

LGTM thanks

@ghaskins
Copy link
Contributor

LGTM, will squash merge it in.

@ghaskins ghaskins merged commit 2d99f80 into hyperledger-archives:master Jul 22, 2016
@juliancarrivick-ibm juliancarrivick-ibm deleted the issue-2266 branch July 25, 2016 00:17
srderson pushed a commit that referenced this pull request Jul 26, 2016
* Fix Issue #809
Add Error message when a user attempts an action other than deploy when they are running their own chaincode and in Developer Mode

* Add initial Logging BDD Tests, still a WIP - logic needs to be implemented

* Still a WIP - Got first 2 tests working, still need to tweak logic for final 2 tests

Implemented deploy chaincode by name in BDD step

Move other deploy steps to use refactored deploy code

Refactored test util to be able to return full container name from peer name

Log checking implemented, need to tweak logic to make tests pass

Ensure first 2 logging tests pass

* Get final 2 logging bdd tests working

* Fix CI errors when running chaincode in container

* Update host.sh to correspond with #2267 to allow tests to run
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

ImportError: No module named google.protobuf error only in Travis
4 participants