Skip to content
This repository has been archived by the owner on Mar 30, 2018. It is now read-only.

Fix issue 2168 #2205

Merged
merged 1 commit into from
Jul 14, 2016
Merged

Fix issue 2168 #2205

merged 1 commit into from
Jul 14, 2016

Conversation

genggjh
Copy link
Contributor

@genggjh genggjh commented Jul 14, 2016

Description

Cache configuration attributes to help improve performance: organization, country, rootpath, cadir

Motivation and Context

Fixes #2168

How Has This Been Tested?

Checklist:

  • I have added a Signed-off-by.
  • [] I have either added documentation to cover my changes or this change requires no new documentation.
  • I have either added unit tests to cover my changes or this change requires no new tests.
  • I have run golint and have fixed valid warnings in code I have added or modified. This tool generates false positives so you may choose to ignore some warnings. The goal is clean, consistent, and readable code.

Signed-off-by: David Geng [email protected]

@dco-bot
Copy link

dco-bot commented Jul 14, 2016

Hi genggjh,

Thanks for submitting this pull request!

I can confirm that the DCO1.1 sign-off has been included. It is okay to process this pull request.

dco-bot

@christo4ferris
Copy link
Contributor

@genggjh thanks for doing this! LGTM

@srderson
Copy link
Contributor

@JonathanLevi any comments?

@JonathanLevi
Copy link
Contributor

@srderson, @genggjh This is really great, thanks!

Much better than loading values from Viper... 'at some point' at run-time.

@srderson
Copy link
Contributor

srderson commented Jul 14, 2016

@genggjh thanks! @JonathanLevi @christo4ferris thanks for the review! LGTM

@srderson srderson merged commit 7206c1b into hyperledger-archives:master Jul 14, 2016
@srderson srderson mentioned this pull request Jul 14, 2016
4 tasks
lhaskins pushed a commit to lhaskins/fabric-archive that referenced this pull request Oct 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CertificateSpec doesn't include Organization and Country ... why not?
5 participants