This repository has been archived by the owner on Jan 27, 2022. It is now read-only.
Worker key refresh policy implementation #671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manju956
requested review from
danintel,
dcmiddle,
EugeneYYY,
karthikamurthy,
manojgop,
pankajgoyal2,
Ram-srini,
rranjan3,
SriharshaSubbakrishna and
TomBarnes
as code owners
|
This pull request introduces 5 alerts when merging 1df89b3 into ed424e7 - view on LGTM.com new alerts:
|
manju956
force-pushed
the
worker_key_refresh
branch
from
1df89b3 to
48318d2
Compare
|
This pull request introduces 1 alert when merging 48318d2 into ed424e7 - view on LGTM.com new alerts:
|
manju956
force-pushed
the
worker_key_refresh
branch
from
48318d2 to
730cab4
Compare
danintel
changed the title
danintel
approved these changes
Sep 1, 2020
common/cpp/tcf_error.h
Outdated
| @@ -42,7 +42,9 @@ typedef enum { | |||
| TCF_ERR_SYSTEM_BUSY = -10, | |||
| TCF_ERR_CRYPTO = -11, | |||
| /** Invalid workload ID */ | |||
| TCF_ERR_INVALID_WORKLOAD = -12 | |||
| TCF_ERR_INVALID_WORKLOAD = -12, | |||
| /* Enclave key refresh error */ | |||
There was a problem hiding this comment.
Make this comment Doxygen-friendly. Change
/* Enclave key refresh error */
to
/** Enclave key refresh error */
| worker_info = EnclaveManager.create_json_worker( | ||
| self._enclave_info, self._config) | ||
| logger.info( | ||
| "Persiting updated worker details after key refresh - %s", |
There was a problem hiding this comment.
Change Persiting to Persisting.
| @@ -349,12 +375,13 @@ namespace tcf { | |||
| } | |||
| // Calculate final hash | |||
| std::string final_hash_string = ByteArrayToString(hash_1); | |||
| if(!hash_in_data_str.empty()) { | |||
|
|
|||
| //if(!hash_in_data_str.empty()) { | |||
There was a problem hiding this comment.
Is there a reason this is commented out and not deleted?
There was a problem hiding this comment.
Its irrelevant change. Deleted it
| } | ||
| if(!hash_out_data_str.empty()) { | ||
| //} | ||
| //if(!hash_out_data_str.empty()) { |
There was a problem hiding this comment.
Same here--why not delete it?
There was a problem hiding this comment.
Its irrelevant change. Deleted it
danintel
reviewed
Sep 1, 2020
manju956
force-pushed
the
worker_key_refresh
branch
from
730cab4 to
f34c32a
Compare
This feature initiates refresh of worker encryption key pair based on number of work orders processed in case of Singleton worker or number of pre-processed work orders in case of KME worker. A new pair of encryption key is generated in the enclave and the updated enclave signup details are stored in the KvStorage in workers table. Worker encryption key signature is re-computed when encryption key gets refreshed. When a worker key gets refreshed during the work order submission, a specific error code is returned to client to indicate worker key refresh. On receiving this error code, client retrieves the updated worker details and does work order submission again. Signed-off-by: manju956 <[email protected]>
manju956
force-pushed
the
worker_key_refresh
branch
from
f34c32a to
8869f61
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature initiates refresh of worker encryption key pair based on
number of work orders processed in case of Singleton worker or number of
pre-processed work orders in case of KME worker.
A new pair of encryption key is generated in the enclave and the updated
enclave signup details are stored in the KvStorage in workers table.
Worker encryption key signature is re-computed when encryption key gets refreshed.
When a worker key gets refreshed during the work order submission,
a specific error code is returned to client to indicate worker key refresh.
On receiving this error code, client retrieves the updated worker details and
does work order submission again.
Signed-off-by: manju956 [email protected]