Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add names to tokio tasks in Relayer #5592

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Mar 3, 2025

Description

Add names to tokio tasks in Relayer so that each task is recognisable in tokio-console

Drive-by changes

  • Minor method rename run_merkle_tree_hook_syncs to run_merkle_tree_hook_sync.

Related issues

Backward compatibility

Yes

Testing

Locally

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 7f98226

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (9fc5e66) to head (7f98226).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5592   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@ameten ameten enabled auto-merge March 3, 2025 16:08
@ameten ameten added this pull request to the merge queue Mar 3, 2025
Merged via the queue into main with commit b216fa0 Mar 3, 2025
46 checks passed
@ameten ameten deleted the ameten/relayer-staltup-time-analysis branch March 3, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants