fix: operation_status metric inaccuracy #5002
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
new_metric
passed intoset_status_and_update_metrics
was actually using the oldstatus
of the queue operation, causing prepare queue messages to be reflected in metrics as having the status they had in the submit queue. See #5001 for more details.Related issues
Backward compatibility
Yes
Testing
Will check on RC before releasing