feat: Integrate ZKSync Wallet for ChainTechnicalStack-Specific Transaction Signing #4914
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocolSigner implementation for flexible cross-chain signer configuration and management
…to feat/zksync-signer-strategy
…n for ZKSync signer strategy
…to feat/zksync-signer-strategy
xeno097
approved these changes
Dec 16, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
…ction Signing (#4914) ### Description This PR integrates the zksync-ethers wallet implementation for the ZKSync signer strategy. Key changes include: - Added zksync-ethers dependency (v5.10.0) - Updated ZKSyncSignerStrategy to use ZKSyncWallet instead of standard ethers Wallet - Removed outdated TODO comment about ZKSync signer implementation ### Drive-by changes None ### Related issues N/A ### Backward compatibility Yes ### Testing Manual testing --------- Co-authored-by: Morteza Shojaei <[email protected]> Co-authored-by: ljankovic-txfusion <[email protected]> Co-authored-by: ljankovic-txfusion <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
hyperlane-xyz:main
with commit Dec 16, 2024
98ee79c
29 of 32 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the zksync-ethers wallet implementation for the ZKSync signer strategy. Key changes include:
Drive-by changes
None
Related issues
N/A
Backward compatibility
Yes
Testing
Manual testing