Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove unique chain id index from db migration script #4834

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

ameten
Copy link
Contributor

@ameten ameten commented Nov 7, 2024

Description

Remove unique chain id index from db migration script

Related issues

Backward compatibility

Yes

Testing

Manual run of DB migration script

Copy link

changeset-bot bot commented Nov 7, 2024

⚠️ No Changeset found

Latest commit: 52cb4eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.58%. Comparing base (f48cf87) to head (52cb4eb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4834   +/-   ##
=======================================
  Coverage   74.58%   74.58%           
=======================================
  Files         103      103           
  Lines        1515     1515           
  Branches      195      195           
=======================================
  Hits         1130     1130           
  Misses        364      364           
  Partials       21       21           
Components Coverage Δ
core 84.61% <ø> (ø)
hooks 77.77% <ø> (ø)
isms 79.02% <ø> (ø)
token 89.01% <ø> (ø)
middlewares 77.58% <ø> (ø)

@ameten ameten added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 8e50c2a Nov 7, 2024
34 checks passed
@ameten ameten deleted the ameten/remove-unique-chain-id-index-from-db-migration branch November 7, 2024 17:56
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
…e-xyz#4834)

### Description

Remove unique chain id index from db migration script

### Related issues

- Contributes into
hyperlane-xyz#4798

### Backward compatibility

Yes

### Testing

Manual run of DB migration script

---------

Co-authored-by: Danil Nemirovsky <[email protected]>
tiendn pushed a commit to tiendn/hyperlane-monorepo that referenced this pull request Jan 11, 2025
…e-xyz#4834)

### Description

Remove unique chain id index from db migration script

### Related issues

- Contributes into
hyperlane-xyz#4798

### Backward compatibility

Yes

### Testing

Manual run of DB migration script

---------

Co-authored-by: Danil Nemirovsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants