Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better chain selection for single chain #4824

Merged
merged 6 commits into from
Jan 2, 2025

Conversation

xeno097
Copy link
Contributor

@xeno097 xeno097 commented Nov 5, 2024

Description

This PR updates the single chain selection prompt to use a search prompt instead of a select one.

Drive-by changes

  • Adds missing : where the runSingleChainSelectionStep is used.
  • Installs the @inquirer/search package

Related issues

Backward compatibility

  • Yes

Testing

  • Manual

Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: f8ea440

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (a5ece3b) to head (f8ea440).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4824   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

Copy link
Contributor

@ltyu ltyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGTM

xeno097 and others added 3 commits January 2, 2025 16:09
….com:hyperlane-xyz/hyperlane-monorepo into xeno/better-chain-selection-for-single-chain
@xeno097 xeno097 added this pull request to the merge queue Jan 2, 2025
Merged via the queue into main with commit d35502f Jan 2, 2025
40 checks passed
@xeno097 xeno097 deleted the xeno/better-chain-selection-for-single-chain branch January 2, 2025 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Better chain selection for single chain selection
4 participants