feat: add block tag enum for validating reorgPeriod #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pbio <[email protected]>
🦋 Changeset detectedLatest commit: 4624d3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paulbalaji
commented
Oct 23, 2024
paulbalaji
commented
Oct 23, 2024
paulbalaji
changed the title
EthJsonRpcBlockParameterTag enum for reorgPeriod
tkporter
approved these changes
Oct 23, 2024
Mo-Hussain
reviewed
Oct 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4739 +/- ##
=======================================
Coverage 73.74% 73.74%
=======================================
Files 100 100
Lines 1436 1436
Branches 187 187
=======================================
Hits 1059 1059
Misses 356 356
Partials 21 21
|
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
### Description - feat: add `EthJsonRpcBlockParameterTag` enum for validating reorgPeriod - cli will check that reorgPeriod is either a number or one of the appropriate tags, but the underlying schema is still left loose to be forwards-compatible - exporting the enum will also let us use this in unit tests on the registry side ### Drive-by changes na ### Related issues na ### Backward compatibility ye ### Testing ci --------- Signed-off-by: pbio <[email protected]>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
### Description - feat: add `EthJsonRpcBlockParameterTag` enum for validating reorgPeriod - cli will check that reorgPeriod is either a number or one of the appropriate tags, but the underlying schema is still left loose to be forwards-compatible - exporting the enum will also let us use this in unit tests on the registry side ### Drive-by changes na ### Related issues na ### Backward compatibility ye ### Testing ci --------- Signed-off-by: pbio <[email protected]>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
### Description - feat: add `EthJsonRpcBlockParameterTag` enum for validating reorgPeriod - cli will check that reorgPeriod is either a number or one of the appropriate tags, but the underlying schema is still left loose to be forwards-compatible - exporting the enum will also let us use this in unit tests on the registry side ### Drive-by changes na ### Related issues na ### Backward compatibility ye ### Testing ci --------- Signed-off-by: pbio <[email protected]>
tiendn
pushed a commit
to tiendn/hyperlane-monorepo
that referenced
this pull request
Oct 25, 2024
### Description - feat: add `EthJsonRpcBlockParameterTag` enum for validating reorgPeriod - cli will check that reorgPeriod is either a number or one of the appropriate tags, but the underlying schema is still left loose to be forwards-compatible - exporting the enum will also let us use this in unit tests on the registry side ### Drive-by changes na ### Related issues na ### Backward compatibility ye ### Testing ci --------- Signed-off-by: pbio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EthJsonRpcBlockParameterTagenum for validating reorgPeriodDrive-by changes
na
Related issues
na
Backward compatibility
ye
Testing
ci