refactor: implement outbound and inbound warp route amount transforms #4729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 21b0b24 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
nambrot
reviewed
Oct 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## audit-q3-2024 #4729 +/- ##
=================================================
+ Coverage 73.74% 73.75% +0.01%
=================================================
Files 100 100
Lines 1436 1429 -7
Branches 187 185 -2
=================================================
- Hits 1059 1054 -5
+ Misses 356 354 -2
Partials 21 21
|
…use in scaling Warp Routes
yorhodes
changed the title
nambrot
approved these changes
Oct 22, 2024
yorhodes
added a commit
that referenced
this pull request
Nov 6, 2024
…#4729) ### Description - implements `_outbound` and `_inbound` internal amount transforms for use in scaling warp routes - simplify `HypNativeScaled` implementation ### Backward compatibility Yes ### Testing Existing HypNative Scaled Unit Tests
yorhodes
added a commit
that referenced
this pull request
Nov 6, 2024
…#4729) ### Description - implements `_outbound` and `_inbound` internal amount transforms for use in scaling warp routes - simplify `HypNativeScaled` implementation ### Backward compatibility Yes ### Testing Existing HypNative Scaled Unit Tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
_outboundand_inboundinternal amount transforms for use in scaling warp routesHypNativeScaledimplementationBackward compatibility
Yes
Testing
Existing HypNative Scaled Unit Tests