-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: warp init
simplified config
#4504
Conversation
…it command to promt for default ism option
🦋 Changeset detectedLatest commit: 96ca5ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4504 +/- ##
=======================================
Coverage 73.85% 73.85%
=======================================
Files 100 100
Lines 1423 1423
Branches 181 181
=======================================
Hits 1051 1051
Misses 351 351
Partials 21 21
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ltyu before pushing the pr I tried the |
Co-authored-by: Lee <[email protected]>
…src/config/warp.ts Co-authored-by: Lee <[email protected]>
ah make sense. i'm okay with it being biased to one of them. |
…to xeno/warp-route-simplified-config
…to xeno/warp-route-simplified-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…to xeno/warp-route-simplified-config
Description
This PR updates the ISM configuration prompting for the
warp init
command allowing the user to choose if a trusted ISM should be used by default or a configured one.Before:
After:
Drive-by changes
Related issues
Backward compatibility
Testing