Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement OPL2ToL1Ism contracts #4319

Merged
merged 10 commits into from
Aug 19, 2024
Merged

feat: implement OPL2ToL1Ism contracts #4319

merged 10 commits into from
Aug 19, 2024

Conversation

aroralanuk
Copy link
Contributor

@aroralanuk aroralanuk commented Aug 14, 2024

Description

Implementing the OPL2ToL1Hook and OPL2ToL1Ism` contracts for using the Optimism native bridge for sending messages from the L2 to L1.

  • Optimism needs double call encoding for the direct portal call because the portal itself calls the l1Messenger which then directs it to the ism.

Drive-by changes

None

Related issues

Backward compatibility

Yes

Testing

Unit testing with mocks for OP contracts

Copy link

changeset-bot bot commented Aug 14, 2024

🦋 Changeset detected

Latest commit: 7dbdc18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@hyperlane-xyz/core Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/cli Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (63abe56) to head (7dbdc18).
Report is 26 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #4319   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          1       1           
  Lines         14      14           
=====================================
  Misses        14      14           
Components Coverage Δ
core ∅ <ø> (∅)
hooks ∅ <ø> (∅)
isms ∅ <ø> (∅)
token ∅ <ø> (∅)
middlewares ∅ <ø> (∅)

@aroralanuk aroralanuk marked this pull request as ready for review August 15, 2024 12:56
solidity/contracts/interfaces/optimism/IOptimismPortal.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
solidity/contracts/hooks/OPL2ToL1Hook.sol Show resolved Hide resolved
solidity/contracts/hooks/OPL2ToL1Hook.sol Outdated Show resolved Hide resolved
solidity/contracts/libs/OPL2ToL1Metadata.sol Show resolved Hide resolved
solidity/contracts/libs/OPL2ToL1Metadata.sol Outdated Show resolved Hide resolved
solidity/contracts/isms/hook/OPL2ToL1Ism.sol Outdated Show resolved Hide resolved
@aroralanuk aroralanuk enabled auto-merge August 19, 2024 00:43
@aroralanuk aroralanuk added this pull request to the merge queue Aug 19, 2024
Merged via the queue into main with commit 6f377f1 Aug 19, 2024
33 of 39 checks passed
@aroralanuk aroralanuk deleted the kunal/op-l2-l1 branch August 19, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants