Cosmos grpc fallbackprovider #3139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3139 +/- ##
=======================================
Coverage 67.65% 67.65%
=======================================
Files 99 99
Lines 1014 1014
Branches 106 106
=======================================
Hits 686 686
Misses 284 284
Partials 44 44
|
…ation layer instead
daniel-savu
force-pushed
the
dan/cosmos-fallbackprovider
branch
from
fc876ff to
22cbb09
Compare
tkporter
approved these changes
Feb 1, 2024
tkporter
approved these changes
Feb 5, 2024
…to dan/cosmos-fallbackprovider
ltyu
pushed a commit
to ltyu/hyperlane-monorepo
that referenced
this pull request
Mar 13, 2024
### Description Implements grpc fallback provider logic for cosmos - initially tried implementing the fallback provider deprioritization logic at middleware level like in the EVM. The difference between ethers and cosmrs is that in the latter, middleware can only live at the transport layer (`tower` crate level). - based on this github [issue](hyperium/tonic#733), that actually doesn't look possible, because the http::Request type isn't `Clone` so it can't be submitted to multiple providers - ended up implementing the fallback provider at the application layer, by keeping an array of grpc channels - There is now a `call` method in `hyperlane_core::FallbackProvider` which I'm actually really happy with. This method handles the fallbackprovider-specific logic by taking in an async closure, running it on each provider, and iterating providers if the closure call fails. In `grpc.rs` you can see how this is slightly verbose but I think it's quite manageable. The only part that bugs me is having to duplicate `Pin::from(Box::from(future))`, but that's need afaict because the regular closure returns an anonymous type - adds `grpcUrls` and `customGrpcUrls` config items - tests the cosmos fallback provider e2e ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues - Fixes: hyperlane-xyz/issues#998 ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements grpc fallback provider logic for cosmos
towercrate level).Cloneso it can't be submitted to multiple providerscallmethod inhyperlane_core::FallbackProviderwhich I'm actually really happy with. This method handles the fallbackprovider-specific logic by taking in an async closure, running it on each provider, and iterating providers if the closure call fails. Ingrpc.rsyou can see how this is slightly verbose but I think it's quite manageable. The only part that bugs me is having to duplicatePin::from(Box::from(future)), but that's need afaict because the regular closure returns an anonymous typegrpcUrlsandcustomGrpcUrlsconfig itemsDrive-by changes
Related issues
Backward compatibility
Testing