feat: better chain selection for single chain #4824
+85
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…search prompt instead of a select one
…ad of a simple select
🦋 Changeset detectedLatest commit: 87e8e3e The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4824 +/- ##
=======================================
Coverage 74.27% 74.27%
=======================================
Files 101 101
Lines 1481 1481
Branches 192 192
=======================================
Hits 1100 1100
Misses 360 360
Partials 21 21
|
paulbalaji
reviewed
Nov 5, 2024
| @@ -11,6 +11,7 @@ | |||
| "@inquirer/core": "9.0.10", | |||
| "@inquirer/figures": "1.0.5", | |||
| "@inquirer/prompts": "^3.0.0", | |||
| "@inquirer/search": "^3.0.1", | |||
There was a problem hiding this comment.
not for this PR but could you create a separate issue to investigate and bump up the inquirer packages across the board to more recent versions?
i ask because prompts/figures don't look upto date, and v3 of search seems to be wanting v10+ of core (we only specify v9 here)
There was a problem hiding this comment.
will do sir! thanks for pointing it out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the single chain selection prompt to use a search prompt instead of a select one.
Drive-by changes
:where therunSingleChainSelectionStepis used.@inquirer/searchpackageRelated issues
Backward compatibility
Testing