Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: warp apply requires multiple calls for multiple updates #4671

Closed
ltyu opened this issue Oct 11, 2024 · 0 comments · Fixed by #4672
Closed

fix: warp apply requires multiple calls for multiple updates #4671

ltyu opened this issue Oct 11, 2024 · 0 comments · Fixed by #4672
Assignees
@ltyu

Comments

@ltyu
Copy link
Contributor

ltyu commented Oct 11, 2024 •
edited
Loading

Problem

Currently, warp apply only updates in place or extends. It cannot do both in a single call. This is problematic because if there are both kinds of updates, then multiple warp apply are needed.

As shown in Renzo's deployment config, a config is added to extend and a new multisig ISM is added for each existing chain.

Update warp apply such that only 1 call is needed for all config updates.
@ltyu ltyu self-assigned this Oct 11, 2024
@ltyu ltyu converted this from a draft issue Oct 11, 2024
@ltyu ltyu moved this to Sprint in Hyperlane Tasks Oct 11, 2024
@ltyu ltyu moved this from Sprint to In Progress in Hyperlane Tasks Oct 11, 2024
@ltyu ltyu mentioned this issue Oct 11, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 12, 2024
@ltyu
fix(cli): Update warp apply to apply changes in single command (#4672)
a4d5d69 
### Description
This PR fixes a limitation in `warp apply` such that it can only extend
_or_ update an existing warp route. This means that for configs with
both changes require `warp apply` to be called multiple times. An
example is when Renzo deploys to new chain, and it needs to update the
existing ISMs.


### Related issues
- Fixes #4671 

### Backward compatibility
Yes

### Testing
Manual/Unit Tests
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperlane Tasks Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ltyu ltyu

Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cli): Update warp apply to apply changes in single command hyperlane-xyz/hyperlane-monorepo
1 participant
@ltyu