chore(ci): Add clippy job to check error #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LucioFranco Although I think you would not like running clippy on CI as you removed it #1288, I would like to ask your opinion. This time, setting it to only detect errors in order to reduce the possibility of blocking CI. I would think it is valuable because it allows us to notice important aspects. |
djc
approved these changes
Sep 3, 2024
|
Let's try applying it at this stage and see what the impact is. If it becomes an overhead for development, I think we can easily remove it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
clippyjob to check only error to detect some kind of error like #1908 which is difficult to find.