Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support specifying exact services in reflection #682

Closed
hatstand opened this issue Jun 16, 2021 · 0 comments · Fixed by #1042
Closed

Support specifying exact services in reflection #682

hatstand opened this issue Jun 16, 2021 · 0 comments · Fixed by #1042

Comments

@hatstand
Copy link

hatstand commented Jun 16, 2021 •
edited
Loading

Feature Request

Crates

tonic-reflection

Motivation

Currently the reflection service accepts a FileDescriptorSet and announces all services within. A FileDescriptorSet may contain a multitude of services, whereas only some (or likely 1) are served so it should be possible to only announce specific services.

Proposal

Ideally, automatic introspection of which services have actually been added to the Server.

Alternatives

  • Filter services from the existing FileDescriptorSet based on the NAME of any services that have been added to the Server.
  • Support an explicit list of services by string or ServiceDescriptorProtos.

Thanks!
zombiezen added a commit to zombiezen/tonic that referenced this issue Jul 28, 2022
@zombiezen
Add with_service_name method
f260d1e 
Fixes hyperium#682
zombiezen added a commit to zombiezen/tonic that referenced this issue Jul 28, 2022
@zombiezen
reflection: add with_service_name method
44f7eb1 
Fixes hyperium#682
zombiezen added a commit to zombiezen/tonic that referenced this issue Jul 28, 2022
@zombiezen
reflection: add with_service_name method
043357d 
Fixes: hyperium#682
@zombiezen zombiezen mentioned this issue Jul 28, 2022
Merged
LucioFranco added a commit that referenced this issue Jul 29, 2022
@zombiezen @LucioFranco
reflection: add with_service_name method (#1042)
4288fd3 
* reflection: add with_service_name method

Fixes: #682

* Update tonic-reflection/src/server.rs

Co-authored-by: Lucio Franco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

reflection: add with_service_name method zombiezen/tonic
1 participant
@hatstand