impl Display for transport::Error includes the source
#632
Labels
Comments
davidpdrsn
added a commit
that referenced
this issue
May 7, 2021
At Embark we have a little helper function that converts a `&dyn std::error::Error` into a `String` by walking the full chain of sources (with `std::error::Error::source`) and joining them into a `String`. We use that where we log errors to get as much information as possible about whats causing an error. Works particularly well with anyhow's `.context()` method. However since `tonic::transport::Error` include its cause in their `Display` impl we get the sources more than once. As the cause can already be obtained through `std::error::Error::source` no information should be lost by doing this. Fixes #632
davidpdrsn
added a commit
that referenced
this issue
May 27, 2021
At Embark we have a little helper function that converts a `&dyn std::error::Error` into a `String` by walking the full chain of sources (with `std::error::Error::source`) and joining them into a `String`. We use that where we log errors to get as much information as possible about whats causing an error. Works particularly well with anyhow's `.context()` method. However since `tonic::transport::Error` include its cause in their `Display` impl we get the sources more than once. As the cause can already be obtained through `std::error::Error::source` no information should be lost by doing this. Fixes #632
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This leads to the
Displayrepresentation being quite large in some cases. I think a better approach is to include the source inError::sourceso its up to users how much information they want to show.The text was updated successfully, but these errors were encountered: