Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connector implementation crates have to pick http1/http2 #2376

Closed
sfackler opened this issue Dec 24, 2020 · 0 comments · Fixed by #2377
Closed

Connector implementation crates have to pick http1/http2 #2376

sfackler opened this issue Dec 24, 2020 · 0 comments · Fixed by #2377
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.

Comments

@sfackler
Copy link
Contributor

The low-level connection APIs like Connected/Connection/HttpConnector all require one of http1 or http2 to be set. This means that external crates like hyper-openssl have to pick one of those features to enable, which is kind of out of scope for what they actually need to do. It would probably make sense for those bits of the client API to only require client and not http1 or http2 to make things less weird.
@seanmonstar seanmonstar added A-client Area: client. E-easy Effort: easy. A task that would be a great starting point for a new contributor. C-feature Category: feature. This is adding a new feature. labels Dec 24, 2020
benesch added a commit to benesch/hyper that referenced this issue Dec 24, 2020
@benesch
Expose client connection types without proto feature
f977688 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
@benesch benesch mentioned this issue Dec 24, 2020
Merged
benesch added a commit to benesch/hyper that referenced this issue Dec 24, 2020
@benesch
feat(client): expose connection types without proto feature
f728a89 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
benesch added a commit to benesch/hyper that referenced this issue Dec 24, 2020
@benesch
feat(client): expose connection types without proto feature
056166b 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
benesch added a commit to benesch/hyper that referenced this issue Dec 24, 2020
@benesch
feat(client): expose connection types without proto feature
8a002cc 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
@paolobarbolini paolobarbolini mentioned this issue Dec 26, 2020
Merged
@fanatid fanatid mentioned this issue Dec 28, 2020
Merged
benesch added a commit to benesch/hyper that referenced this issue Dec 28, 2020
@benesch
feat(client): expose connection types without proto feature
189a9c0 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
seanmonstar pushed a commit that referenced this issue Dec 28, 2020
@benesch
feat(client): expose connect types without proto feature (#2377)
73a59e5 
Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix #2376.
BenxiangGe pushed a commit to BenxiangGe/hyper that referenced this issue Jul 26, 2021
@benesch
feat(client): expose connect types without proto feature (hyperium#…
b1f67bb 
…2377)

Make it possible to refer to Connected, Connection, HttpConnector, etc.
without enabling either of the http1/http2 features. This makes feature
selection work better for downstream libraries like hyper-openssl, which
don't want to commit to any particular protocol.

Fix hyperium#2376.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-client Area: client. C-feature Category: feature. This is adding a new feature. E-easy Effort: easy. A task that would be a great starting point for a new contributor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose client connection types without proto feature benesch/hyper
2 participants
@seanmonstar @sfackler