Fix HeaderMap::drain double-free if drain iterator is forgotten #357

seanmonstar · 2019-11-25T18:22:45Z

Fixes #354

cc @Qwaz thanks for the report!

hawkw

The approach used here looks correct to me. I left some comments on nits we may want to address.

src/header/map.rs

hawkw · 2019-11-25T18:40:24Z

tests/header_map.rs

+}
+
+#[test]
+fn drain_forget() {


Should there also be a test for mem::forgetting a ValueDrain returned by a Drain?

seanmonstar requested a review from carllerche November 25, 2019 18:22

hawkw approved these changes Nov 25, 2019

View reviewed changes

Fix HeaderMap::drain double-free if drain iterator is forgotten

125e909

seanmonstar force-pushed the drain-double-free branch from 9f5df69 to 125e909 Compare November 25, 2019 19:24

seanmonstar merged commit 82d53db into master Nov 25, 2019

seanmonstar deleted the drain-double-free branch November 25, 2019 19:36

roy-work mentioned this pull request Jan 9, 2020

Correct affected version range on RUSTSEC-2019-003[34] to patched at 0.1.20 rustsec/advisory-db#221

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix HeaderMap::drain double-free if drain iterator is forgotten #357

Fix HeaderMap::drain double-free if drain iterator is forgotten #357

seanmonstar commented Nov 25, 2019

hawkw left a comment

hawkw Nov 25, 2019

Fix HeaderMap::drain double-free if drain iterator is forgotten #357

Fix HeaderMap::drain double-free if drain iterator is forgotten #357

Conversation

seanmonstar commented Nov 25, 2019

hawkw left a comment

Choose a reason for hiding this comment

hawkw Nov 25, 2019

Choose a reason for hiding this comment