Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytes: require 0.4.4 #350

Closed
wants to merge 1 commit into from
Closed

Conversation

mathstuf
Copy link
Contributor

Various APIs used in this crate were added in 0.4.4.

@mathstuf
Copy link
Contributor Author

Hrm. Seems bytes itself needs some work for minimal-versions in some cases. I'll have a followup within a few days.

This version is compatible with the minimal-versions flag.
@mathstuf
Copy link
Contributor Author

Requires a release of tokio-rs/bytes#312

seanmonstar
seanmonstar previously approved these changes Nov 26, 2019
@seanmonstar seanmonstar dismissed their stale review November 26, 2019 18:05

didn't realize it wasn't ready

@mathstuf
Copy link
Contributor Author

I poked the bottom of this PR hole; hopefully it can cause some movement to let this get merged :) .

@carllerche
Copy link
Collaborator

looks like a conflict ::(

@mathstuf
Copy link
Contributor Author

Not surprising; I'll rebase once the dependent PRs are merged (and have a release on crates.io to depend on).

@dekellum
Copy link
Contributor

Conflict with #364 and specifically 845fdd1?

@mathstuf
Copy link
Contributor Author

Well, this might need to go to 0.1.x as well now because of that :) .

@mathstuf mathstuf changed the base branch from master to 0.1.x November 27, 2019 18:37
@dekellum
Copy link
Contributor

Branch whack-a-mole! Seriously, thanks for trying to fix this. I hope there is a potential for an 0.1.21 with the fix, as I suspect some projects will need to support both http 0.1 and 0.2 for some transition period.

@mathstuf
Copy link
Contributor Author

I'll probably be back for 0.2 at some point. I've got a lot of plates in the air for my own set of crates at the moment before I can start to actually fix everything :) .

@mathstuf
Copy link
Contributor Author

Ping?

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, just realized this requires bytes 0.4.13 but the latest is 12? Is there a reason for 13?

@LucioFranco
Copy link
Member

@mathstuf is this something we still want to go with or should we close this in favor of ensuring 0.5 has all the fixes we need?

@mathstuf
Copy link
Contributor Author

Oh, my bad. I thought this was the bottom of my stack. This will need the PR mentioned above first. Sorry for the noise. Going down one level deeper.

@kaj
Copy link

kaj commented Nov 12, 2020

If there is action on #440 this should probably just be closed as semi-duplicate.

@mathstuf
Copy link
Contributor Author

I'm more interested in minimum-versions support, so if that fixes it, I'm fine with that.

@robjtede
Copy link

this can be closed

@mathstuf
Copy link
Contributor Author

It looks like #440 also got closed. Would another minimal versions support PR make it any further?

@seanmonstar
Copy link
Member

Yea, it'd be a good thing to add to CI. Sorry we missed these, but we have more attention now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants