Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use lints.rust.unexpected_cfgs in manifest #785

Merged
merged 1 commit into from
Jul 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions .github/workflows/CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,6 @@ jobs:
run: ./ci/h2spec.sh
if: matrix.rust == 'stable'

unexpected-cfgs:
runs-on: ubuntu-latest
needs: [style]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@nightly
- uses: Swatinem/rust-cache@v2
- run: cargo check --all-features
env:
RUSTFLAGS: >-
-D unexpected_cfgs
--cfg h2_internal_check_unexpected_cfgs
--check-cfg=cfg(h2_internal_check_unexpected_cfgs,fuzzing)

#clippy_check:
# runs-on: ubuntu-latest
# steps:
Expand Down
3 changes: 3 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,9 @@ env_logger = { version = "0.10", default-features = false }
tokio-rustls = "0.26"
webpki-roots = "0.26"

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ["cfg(fuzzing)"] }

[package.metadata.docs.rs]
features = ["stream"]

Expand Down
1 change: 0 additions & 1 deletion src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@
clippy::undocumented_unsafe_blocks
)]
#![allow(clippy::type_complexity, clippy::manual_range_contains)]
#![cfg_attr(not(h2_internal_check_unexpected_cfgs), allow(unexpected_cfgs))]
#![cfg_attr(test, deny(warnings))]

macro_rules! proto_err {
Expand Down