perf: optimize header list size calculations #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noah-Kennedy
force-pushed
the
noah/speed-up-decoding
branch
from
be897a2
to
d5b89a2
Compare
|
Accidentally targeted it at 0.3, though I think this is enough of a perf improvement to justify a backport. We can just forwardport this to 0.4 after I guess? |
Noah-Kennedy
force-pushed
the
noah/speed-up-decoding
branch
2 times, most recently
from
dff5782
to
eb64392
Compare
This speeds up loading blocks in cases where we have many headers already.
Noah-Kennedy
force-pushed
the
noah/speed-up-decoding
branch
from
eb64392
to
0e7ca68
Compare
Noah-Kennedy
changed the title
Noah-Kennedy
changed the title
rushilmehra
reviewed
Feb 22, 2024
| @@ -892,6 +901,8 @@ impl HeaderBlock { | |||
|
|
|||
| headers_size += decoded_header_size(name.as_str().len(), value.len()); | |||
| if headers_size < max_header_list_size { | |||
| self.field_size += | |||
| decoded_header_size(name.as_str().len(), value.len()); | |||
There was a problem hiding this comment.
Should we check that decoded_header_size won't exceed max_header_list_sized?
There was a problem hiding this comment.
that is covered under other checks elsewhere
There was a problem hiding this comment.
Nvm, that's exactly what this does
There was a problem hiding this comment.
Yeah I don't know why I said that lol, it's literally checked right here.
seanmonstar
approved these changes
Feb 22, 2024
rushilmehra
approved these changes
Feb 22, 2024
seanmonstar
pushed a commit
that referenced
this pull request
Feb 22, 2024
This speeds up loading blocks in cases where we have many headers already.
seanmonstar
pushed a commit
that referenced
this pull request
Feb 22, 2024
This speeds up loading blocks in cases where we have many headers already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This speeds up loading blocks in cases where we have many headers already.