Use RST_STREAM(NO_ERROR) in case server early respond (#633) #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Http2 Server are allowed to early respond without fully consuming client input stream, but must respond with an error code of NO_ERROR when sending RST_STREAM. Nginx treat any other error code as fatal if not done so Commit change error code from CANCEL to NO_ERROR, when the server is early responding to the client hyperium#633 https://trac.nginx.org/nginx/ticket/2376
seanmonstar
approved these changes
Aug 15, 2022
|
Thanks so much, the commit and message and comments were all a pleasure to review. <3 |
DDtKey
added a commit
to DDtKey/h2
that referenced
this pull request
Jul 21, 2023
- fix of the test's name after changing it in hyperium#634 - additional test that server also sends data frames correctly
This was referenced Jul 21, 2023
seanmonstar
pushed a commit
that referenced
this pull request
Jul 22, 2023
- fix of the test's name after changing it in #634 - additional test that server also sends data frames correctly
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 11, 2024
- fix of the test's name after changing it in hyperium#634 - additional test that server also sends data frames correctly
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 11, 2024
- fix of the test's name after changing it in hyperium#634 - additional test that server also sends data frames correctly
0xE282B0
pushed a commit
to 0xE282B0/h2
that referenced
this pull request
Jan 16, 2024
- fix of the test's name after changing it in hyperium#634 - additional test that server also sends data frames correctly Signed-off-by: Sven Pfennig <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Http2 Server are allowed to early respond without fully
consuming client input stream, but must respond with an
error code of NO_ERROR when sending RST_STREAM.
Nginx treat any other error code as fatal if not done so
Commit change error code from CANCEL to NO_ERROR, when the
server is early responding to the client
#633
https://trac.nginx.org/nginx/ticket/2376