Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't test custom let macro? #34

Closed
didibus opened this issue Oct 24, 2021 · 2 comments
Closed

Can't test custom let macro? #34

didibus opened this issue Oct 24, 2021 · 2 comments

Comments

@didibus
Copy link

didibus commented Oct 24, 2021

It seems let is treated special by RCF:

(defmacro let
  [bindings & exprs]
  100)

(tests
  (! (let [a 1] a))
  % := 100)

;; Test Fail!

When I macro-expand, I see that RCF uses clojure.core/let instead of the dedefined let.
@ggeoffrey
Copy link
Member

ggeoffrey commented Oct 26, 2021 •
edited
Loading

Thank you for the report. This is a bug. I understand the issue and have an idea of how to fix it. I’ll keep you posted.

ggeoffrey added a commit that referenced this issue Oct 28, 2021
@ggeoffrey
Handle custom let macro #34
71074c5
ggeoffrey added a commit that referenced this issue Oct 28, 2021
@ggeoffrey
Handle custom let macro #34
6fa497f
@fjolne fjolne mentioned this issue Jan 2, 2022
Closed
@ggeoffrey
Copy link
Member

Related to #40

@dustingetz dustingetz mentioned this issue Apr 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dustingetz @didibus @ggeoffrey