This repository has been archived by the owner on May 7, 2023. It is now read-only.
Resolve issue #437 - Fix animation bug in [SignIn] #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #438 +/- ##
==========================================
- Coverage 62.72% 62.68% -0.04%
==========================================
Files 108 108
Lines 2468 2471 +3
Branches 394 396 +2
==========================================
+ Hits 1548 1549 +1
- Misses 792 794 +2
Partials 128 128
Continue to review full report at Codecov.
|
DevYuns
changed the title
hyochan
approved these changes
Jul 28, 2021
Merged
imjlk
pushed a commit
to imjlk/hackatalk
that referenced
this pull request
Aug 19, 2021
`transform` animation value is not preserved between render on mobile. This is the reason that `scale` is return to origin when writing a text on `textInput` which invokes `re-render`. So I changed animation value from `scale` to `width` and `height`. But there is a bug about `withSpring` function on `web`, then I splits an animation value according to platform. This bug seems to have related with `react-native-web`. You can check relate issue with [here](software-mansion/react-native-reanimated#1804) or [here](necolas/react-native-web#1935).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify project
client
Description
transformanimation value is not preserved between render on mobile. This is the reason thatscaleis return to origin when writing a text ontextInputwhich invokesre-render. So I changed animation value fromscaletowidthandheight.But there is a bug about
withSpringfunction onweb, then I splits an animation value according to platform.This bug seems to have related with
react-native-web. You can check relate issue with here or here.Related Issues
Resolve #437
Tests
N/A
Checklist
Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.yarn lint && yarn tscyarn testoryarn test -uif you need to update snapshot.