Skip to content
This repository has been archived by the owner on May 7, 2023. It is now read-only.

Migrate to reanimated v2 for logo animation #431

Merged

Conversation

DevYuns
Copy link
Contributor

@DevYuns DevYuns commented Jul 21, 2021

Specify project

Client

Description

logo animation in SignIn page is made with reanimated v1. So migrating to v2.

Related Issues

N/A

Tests

I added the following tests:

Add mock function for reanimated in jestSetup.ts.

Checklist

Before you create this PR confirms that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • Run yarn test or yarn test -u if you need to update snapshot.
  • I am willing to follow-up on review comments in a timely manner.

@CLAassistant
Copy link

CLAassistant commented Jul 21, 2021

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #431 (9c38ed4) into master (1699328) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          62       62           
  Lines         977      977           
  Branches       99       99           
=======================================
  Hits          730      730           
  Misses        207      207           
  Partials       40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1699328...9c38ed4. Read the comment docs.

@hyochan hyochan added 🚽 migration Activities due to changes in framework 📱 client labels Jul 21, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely great~!! We finally remove the redash legacy!

@hyochan hyochan merged commit 7f60fed into hyochan:master Jul 21, 2021
@hyochan
Copy link
Owner

hyochan commented Jul 21, 2021

@all-contributors Please add @DevYuns for code, test.

@allcontributors
Copy link
Contributor

@hyochan

I've put up a pull request to add @DevYuns! 🎉

imjlk pushed a commit to imjlk/hackatalk that referenced this pull request Aug 19, 2021
* Migrate to react-native-reanimated-v2 for logo animation in [SiginIn] page

* Fix test fail
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📱 client 🚽 migration Activities due to changes in framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants