-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2 implementation #94 #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed deprecated note in the `readme`. - Completely remove prepare. - Upgrade billingclient to 2.0.3 which is currently recent in Sep 15 2019. - Remove [IInAppBillingService] binding since billingClient has its own functionalities. - Add [DoobooUtils] and add `getBillingResponseData` that visualizes erorr codes better. - `buyProduct` no more return asyn result. It rather relies on the `purchaseUpdatedListener`. - Add feature method `acknowledgePurchaseAndroid` . - Implment features in new releases. - enforce to `finishTransaction` after purchases. - Work with `purchaseUpdated` and `purchaseError` listener as in android. - Feature set from `react-native-iap v3`. - Should call finish transaction in every purchase request. - Add `IAPPromotionObserver` cocoa touch file - Convert dic to json string before invoking purchase-updated. - Add `getPromotedProductIOS` and `requestPromotedProductIOS` methods. - Implement clearTransaction for ios - Include `purchasePromoted` stream that listens to `iap-promoted-product`.
Closed
@kwmt Hi there~ Coming from #69, I've made some breaking changes to work on this
P.S. Fixed on my own. Thanks. |
- Attempt to fix testing.
- `finishTransaction` abstracts `finishTransactionIOS`, `acknowledgePurchaseAndroid`, and `consumePurchaseAndroid`. - Renamed `PurchaseErrorItem` to `PurchaseResult`.
hyochan
changed the title
[WIP] Version 2 implementation #94
Version 2 implementation #94
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honored to re-implement plugin for new generation followed by the discussion in #93 🎉.
readme
.travis
.readme
for breaking features.finishTransaction
.acknowledgePurchaseAndroid
,consumePurchaseAndroid
,finishTransactionIOS
.Android
getBillingResponseData
that visualizes erorr codes better.buyProduct
no more return asyn result. It rather relies on thepurchaseUpdatedListener
.acknowledgePurchaseAndroid
acknowledgePurchaseAndroid
.consumePurchase
toconsumePurchaseAndroid
in dart side.buyProduct
torequestPurchase
.buySubscription
torequestSubscription
.iOS
finishTransaction
after purchases.purchaseUpdated
andpurchaseError
listener as in android.react-native-iap v3
.IAPPromotionObserver
cocoa touch filegetPromotedProductIOS
andrequestPromotedProductIOS
methodspurchasePromoted
stream that listens toiap-promoted-product
.